Merge pull request #5 from tiendc/improve-FindMissingItemIDs

Improve FindMissingItemIDs by checking empty slice first
tiendc · Dec 18, 2023 · 0b52ad5 · 0b52ad5
2 parents 7b0908a + 5dbb994
commit 0b52ad5
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 18 deletions.
diff --git a/templates/boilv4/mysql/103_model_utils.go.tpl b/templates/boilv4/mysql/103_model_utils.go.tpl
@@ -41,6 +41,9 @@ func (s {{$alias.UpSingular}}Slice) FindItemByID(id {{$column.Type}}) *{{$alias.
 // FindMissingItemIDs find all item IDs that are not in the list
 // NOTE: the input ID slice should contain unique values
 func (s {{$alias.UpSingular}}Slice) FindMissingItemIDs(expectedIDs []{{$column.Type}}) []{{$column.Type}} {
+    if len(s) == 0 {
+        return expectedIDs
+    }
     result := []{{$column.Type}}{}
     mapChk := s.ToIDMap()
     for _, id := range expectedIDs {
@@ -100,6 +103,9 @@ func (s {{$alias.UpSingular}}Slice) FindItemByID(id {{$column.Type}}) *{{$alias.
 // FindMissingItemIDs find all item IDs that are not in the list
 // NOTE: the input ID slice should contain unique values
 func (s {{$alias.UpSingular}}Slice) FindMissingItemIDs(expectedIDs []{{$column.Type}}) []{{$column.Type}} {
+    if len(s) == 0 {
+        return expectedIDs
+    }
     result := []{{$column.Type}}{}
     mapChk := s.ToIDMap()
     for _, id := range expectedIDs {

diff --git a/templates/boilv4/mysql/singleton/boil_extra.go.tpl b/templates/boilv4/mysql/singleton/boil_extra.go.tpl
@@ -59,12 +59,3 @@ func SplitInChunksBySize[T any](slice []T, chunkSize int) [][]T {
 func unsafeGetString(b []byte) string {
 	return *(*string)(unsafe.Pointer(&b))
 }
-
-func unsafeGetBytes(s string) []byte {
-	return *(*[]byte)(unsafe.Pointer(
-		&struct {
-			string
-			Cap int
-		}{s, len(s)},
-	))
-}
diff --git a/templates/boilv4/postgres/103_model_utils.go.tpl b/templates/boilv4/postgres/103_model_utils.go.tpl
@@ -41,6 +41,9 @@ func (s {{$alias.UpSingular}}Slice) FindItemByID(id {{$column.Type}}) *{{$alias.
 // FindMissingItemIDs find all item IDs that are not in the list
 // NOTE: the input ID slice should contain unique values
 func (s {{$alias.UpSingular}}Slice) FindMissingItemIDs(expectedIDs []{{$column.Type}}) []{{$column.Type}} {
+    if len(s) == 0 {
+        return expectedIDs
+    }
     result := []{{$column.Type}}{}
     mapChk := s.ToIDMap()
     for _, id := range expectedIDs {
@@ -100,6 +103,9 @@ func (s {{$alias.UpSingular}}Slice) FindItemByID(id {{$column.Type}}) *{{$alias.
 // FindMissingItemIDs find all item IDs that are not in the list
 // NOTE: the input ID slice should contain unique values
 func (s {{$alias.UpSingular}}Slice) FindMissingItemIDs(expectedIDs []{{$column.Type}}) []{{$column.Type}} {
+    if len(s) == 0 {
+        return expectedIDs
+    }
     result := []{{$column.Type}}{}
     mapChk := s.ToIDMap()
     for _, id := range expectedIDs {

diff --git a/templates/boilv4/postgres/singleton/boil_extra.go.tpl b/templates/boilv4/postgres/singleton/boil_extra.go.tpl
@@ -59,12 +59,3 @@ func SplitInChunksBySize[T any](slice []T, chunkSize int) [][]T {
 func unsafeGetString(b []byte) string {
 	return *(*string)(unsafe.Pointer(&b))
 }
-
-func unsafeGetBytes(s string) []byte {
-	return *(*[]byte)(unsafe.Pointer(
-		&struct {
-			string
-			Cap int
-		}{s, len(s)},
-	))
-}