Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework filepath (re-)encoding #438

Merged
merged 17 commits into from
May 17, 2022
Merged

Rework filepath (re-)encoding #438

merged 17 commits into from
May 17, 2022

Commits on May 8, 2022

  1. Revert filepath reencoding

    @jennybc
    jennybc committed May 8, 2022
    Configuration menu
    Copy the full SHA
    76b93e6 View commit details
    Browse the repository at this point in the history

  2. Unskip this test

    @jennybc
    jennybc committed May 8, 2022
    Configuration menu
    Copy the full SHA
    8e821c0 View commit details
    Browse the repository at this point in the history

  3. Re-encode to native just prior to fopen() or mio::make_mmap_source()

    @jennybc
    jennybc committed May 8, 2022
    Configuration menu
    Copy the full SHA
    4317c8a View commit details
    Browse the repository at this point in the history

  4. Expose the bytes

    @jennybc
    jennybc committed May 8, 2022
    Configuration menu
    Copy the full SHA
    000790d View commit details
    Browse the repository at this point in the history

  5. Unconditionally encode paths as UTF-8

    @jennybc
    jennybc committed May 8, 2022
    Configuration menu
    Copy the full SHA
    bdecf47 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2022

  1. Clean up comments, remove print debugging

    @jennybc
    jennybc committed May 9, 2022
    Configuration menu
    Copy the full SHA
    1023b1c View commit details
    Browse the repository at this point in the history

Commits on May 11, 2022

  1. Ensure path returned by chr_to_file() is encoded as UTF-8 

    This guards against the scenario where the tempdir's path has non-ascii characters in it.

Presumably that could arise on, say, Windows if the user name has non-ascii characters:

> tempdir()
[1] "C:\\Users\\jenny\\AppData\\Local\\Temp\\Rtmpg30qBQ"
    @jennybc
    jennybc committed May 11, 2022
    Configuration menu
    Copy the full SHA
    2f314b3 View commit details
    Browse the repository at this point in the history

  2. Add more enc2utf8() 

    Everytime we use a base R path-handling function, explicitly re-encode the result as UTF-8.
    @jennybc
    jennybc committed May 11, 2022
    Configuration menu
    Copy the full SHA
    5792653 View commit details
    Browse the repository at this point in the history

  3. Inline the reference object

    @jennybc
    jennybc committed May 11, 2022
    Configuration menu
    Copy the full SHA
    114c671 View commit details
    Browse the repository at this point in the history

  4. Test writing to a non-ascii path

    @jennybc
    jennybc committed May 11, 2022
    Configuration menu
    Copy the full SHA
    8f180e0 View commit details
    Browse the repository at this point in the history

  5. Test read/write of .zip with non-ascii characters in path

    @jennybc
    jennybc committed May 11, 2022
    Configuration menu
    Copy the full SHA
    004f42c View commit details
    Browse the repository at this point in the history

Commits on May 13, 2022

  1. Rewrite this test

    @jennybc
    jennybc committed May 13, 2022
    Configuration menu
    Copy the full SHA
    9777c2e View commit details
    Browse the repository at this point in the history

Commits on May 15, 2022

  1. I now think the problem IS in archive, for Windows and unix 

    Skip this test in non-UTF-8 locales for now
    @jennybc
    jennybc committed May 15, 2022
    Configuration menu
    Copy the full SHA
    a9436d4 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Add a test re: reading fwf from non-ascii filepath

    @jennybc
    jennybc committed May 17, 2022
    Configuration menu
    Copy the full SHA
    4be132c View commit details
    Browse the repository at this point in the history

  2. Tweaks NEWS

    @jennybc
    jennybc committed May 17, 2022
    Configuration menu
    Copy the full SHA
    e4a6321 View commit details
    Browse the repository at this point in the history

  3. Make versions of basename() and normalizePath() that uphold UTF-8 eve… 

    …rywhere
    @jennybc
    jennybc committed May 17, 2022
    Configuration menu
    Copy the full SHA
    432b918 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into yet-another-filepath-encoding-experiment

    @jennybc
    jennybc committed May 17, 2022
    Configuration menu
    Copy the full SHA
    833e193 View commit details
    Browse the repository at this point in the history