Update snapshots to align with dev rlang #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionel-
reviewed
Jul 21, 2021
There was a problem hiding this comment.
Could you be supplying a named vector of bullets with empty "" names? We now require explicit "*" bullets to align with cli and there's backward-compatibility behaviour for the case of NULL names but not for the case of all "" names.
To make this easier, set_names() is now vectorised so you can do set_names(bullets, "*").
|
Thanks. I'm having trouble to find a clean upgrade path, because rlang 0.4.11 forbids explicit |
|
I'm going to use |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are these changes intended?