Use alternative variant for list columns in frame_data() #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-picked from tidyverse/dplyr@25e95da83.
Cherry-picked from tidyverse/dplyr@25e95da83.
|
Tests now pass (after adb9400). You decide. |
Current coverage is
|
| frame_mat <- matrix(frame_rest, ncol = frame_ncol, byrow = TRUE) | ||
| frame_col <- lapply(seq_len(ncol(frame_mat)), function(i) { | ||
| col <- frame_mat[, i] | ||
| if (any(vapply(col, function(x) is.list(x) || length(x) != 1L, |
There was a problem hiding this comment.
How about pulling this out into is_atomic_scalar()?
There was a problem hiding this comment.
Extracted needs_list_col() (8ed51d8).
krlmlr
added a commit
that referenced
this pull request
Mar 8, 2016
- `frame_data()` now also creates a list column if one of the entries is a list (#32).
krlmlr
pushed a commit
that referenced
this pull request
Mar 8, 2016
- `frame_data()` now also creates a list column if one of the entries is a list (#32). - New `rownames_to_column()` and `column_to_rownames()` functions, replace `add_rownames()` (#11, @zhilongjia).
krlmlr
pushed a commit
that referenced
this pull request
Mar 10, 2016
- Features
- New `as_data_frame.table()` with argument `n` to control name of count column (#22, #23).
- New function `repair_names()` fixes missing and duplicate names (#10, #15, @r2evans).
- `frame_data()` now also creates a list column if one of the entries is a list (#32).
- New `rownames_to_column()` and `column_to_rownames()` functions, replace `add_rownames()` (#11, @zhilongjia).
- Use `tibble` prefix for options (#13, #36).
- Documentation
- Add pre-tibble NEWS (#39, #40).
- Include vignette (#38).
- Expand README.
- Fix typos in documentation.
- Remove use of `src()` from examples.
- Prepare CRAN release
- Use new-style `.travis.yml`
- Use AppVeyor for testing.
- Finer coverage analysis (#37).
- Check with win-builder and valgrind.
- Fix NOTE from `R CMD check`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hadley: This is your implementation, but it fails one of the existing tests. I have an alternative, longer implementation, which passes everything.