chore: Drop fansi and import cli #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to go with r-lib/pillar#663
What is the implication for support inside knitr?
I saw this https://rpubs.com/krlmlr/pillar-focus
Could
set_ansi_hooks()be baked in somehow?Currently, there is no highlighting of code, except for hugodown and pkgdown.
https://tibble.tidyverse.org/articles/tibble.html and https://www.tidyverse.org/blog/2023/08/teach-tidyverse-23/#conflict-resolution-in-the-tidyverse
Rmarkdown and Quarto show dull colors in output quarto-dev/quarto-cli#3730
For example https://r4ds.hadley.nz/logicals#comparisons
Relates to #475
The PR doesn't break highlighting in pkgdown
hadley/r4ds#1027