Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation updates #1512

Merged
merged 5 commits into from
Feb 23, 2023
Merged

Documentation updates #1512

merged 5 commits into from
Feb 23, 2023

Conversation

krlmlr
Copy link
Member

@krlmlr krlmlr commented Feb 22, 2023

Preview at https://tibble.tidyverse.org/dev/.

Closes #275. Closes #1070. Closes #1151.

@krlmlr krlmlr requested a review from hadley February 22, 2023 16:58
@krlmlr
Copy link
Member Author

krlmlr commented Feb 22, 2023

Can you please provide feedback on the new article (draft) at https://tibble.tidyverse.org/dev/articles/extending.html and on the documentation tweaks?

README.Rmd Outdated Show resolved Hide resolved
@@ -8,4 +8,112 @@ vignette: >
%\VignetteEncoding{UTF-8}
---

This material has moved to <https://vctrs.r-lib.org/articles/pillar.html>.
Tibbles are S3 objects of class `c("tbl_df", "tbl", "data.frame")`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this in a snapshot test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the vignette output relies on other packages, and with that, I get an early alert if something changes.

Co-authored-by: Hadley Wickham <[email protected]>
@krlmlr krlmlr merged commit 6d0effc into main Feb 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants