Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long vector support #916

Closed
krlmlr opened this issue Jul 29, 2021 · 3 comments · Fixed by #962
Closed

Long vector support #916

krlmlr opened this issue Jul 29, 2021 · 3 comments · Fixed by #962
Labels
bug an unexpected problem or unintended behavior
Milestone
3.1.6

Comments

@krlmlr
Copy link
Member

krlmlr commented Jul 29, 2021

is currently unavailable. We should give a clear error message.

tibble::new_tibble(list(), nrow = 2.3e9)
#> Warning in attr(x, "row.names") <- .set_row_names(nrow): NAs introduced by
#> coercion to integer range
#> Error: Corrupt data frame: row.names are missing

Created on 2021-07-29 by the reprex package (v2.0.0.9000)
@krlmlr krlmlr added the bug an unexpected problem or unintended behavior label Jul 29, 2021
@krlmlr krlmlr added this to the 3.1.4 milestone Jul 29, 2021
@krlmlr
Copy link
Member Author

krlmlr commented Aug 6, 2021

@lionel-: What should the behavior be for nrow >= 2^31? Is this vctrs behavior intended:

dput(vctrs::new_data_frame(list(a = 1:10), n = -10L))
#> structure(list(a = 1:10), class = "data.frame", row.names = integer(0))

Created on 2021-08-06 by the reprex package (v2.0.0.9000)

?

@krlmlr krlmlr modified the milestones: 3.1.4, 3.1.5 Aug 7, 2021
@lionel-
Copy link
Member

lionel- commented Aug 16, 2021

This looks like a bug? Negative n should be an error.

@krlmlr krlmlr modified the milestones: 3.1.5, 3.1.6 Sep 26, 2021
This was referenced Oct 24, 2021
Closed
Merged
krlmlr added a commit that referenced this issue Oct 24, 2021
@krlmlr
Merge pull request #962 from tidyverse/f-916-long-vector-error
3a75e62 
- `new_tibble()` checks that the `nrow` argument is nonnegative and less than 2^31 (#916).
krlmlr added a commit that referenced this issue Mar 2, 2022
@krlmlr
Merge tag 'v3.1.6' into docs
52b1080 
tibble 3.1.6

- `set_num_opts()` and `set_char_opts()` are reexported from pillar (#959).
- `view()` uses `rlang::expr_deparse(width = Inf)` to avoid errors with long `|>` pipes (#957).
- `new_tibble()` checks that the `nrow` argument is nonnegative and less than 2^31 (#916).
- `tbl_sum.tbl_df()` has an ellipsis in its formals for extensibility.
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug an unexpected problem or unintended behavior
Projects
None yet
Milestone
3.1.6
Development

Successfully merging a pull request may close this issue.

Check nrow argument tidyverse/tibble
2 participants
@krlmlr @lionel-