use documented method for resetting row names

- also add new test
tidyverse · Mar 17, 2016 · ff74592 · ff74592
1 parent 4f934ef
commit ff74592
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/R/rownames.R b/R/rownames.R
@@ -19,7 +19,7 @@ has_rownames <- function(df) {
 #' rownames(remove_rownames(mtcars))
 remove_rownames <- function(df) {
   stopifnot(is.data.frame(df))
-  attr(df, "row.names") <- .set_row_names(nrow(df))
+  rownames(df) <- NULL
   df
 }
 

diff --git a/tests/testthat/test-rownames.R b/tests/testthat/test-rownames.R
@@ -4,6 +4,7 @@ test_that("has_rownames and remove_rownames", {
   expect_false(has_rownames(iris))
   expect_true(has_rownames(mtcars))
   expect_false(has_rownames(remove_rownames(mtcars)))
+  expect_false(has_rownames(remove_rownames(iris)))
   expect_error(has_rownames(1:10))
 })