Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize all paths, prior conversion to native encoding #499

Merged
merged 1 commit into from
Aug 21, 2018
Merged

Normalize all paths, prior conversion to native encoding #499

merged 1 commit into from
Aug 21, 2018

Commits on Aug 20, 2018

  1. Normalize all paths, prior conversion to native encoding 

    Fixes #498

Prior to b10a1a8,all xls paths were normalized, but we didn't know exactly why. In b10a1a8, I stopped normalizing xls paths, while solving an unrelated path encoding problem presented by R 3.5.

In discussion around #477, @jimhester said:

"I think doing enc2native(normalizePath()) on the R side for both xls and xlsx seems the best option."

I am now taking this wise advice.
    @jennybc
    jennybc committed Aug 20, 2018
    Configuration menu
    Copy the full SHA
    09e9559 View commit details
    Browse the repository at this point in the history