Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure path is in native encoding #477

Merged
merged 8 commits into from
May 11, 2018
Merged

Make sure path is in native encoding #477

merged 8 commits into from
May 11, 2018

Commits on May 4, 2018

  1. Create temporary test sheet with non-ASCII character in filename 

    Use characters representable in Windows-1252 codepage
    @jennybc
    jennybc committed May 4, 2018
    Configuration menu
    Copy the full SHA
    bcaea8f View commit details
    Browse the repository at this point in the history

  2. Don't normalizePath() on xls filepaths

    @jennybc
    jennybc committed May 4, 2018
    Configuration menu
    Copy the full SHA
    945178d View commit details
    Browse the repository at this point in the history

  3. Explicit enc2native()

    @jennybc
    jennybc committed May 4, 2018
    Configuration menu
    Copy the full SHA
    8a8c061 View commit details
    Browse the repository at this point in the history

Commits on May 5, 2018

  1. Work on the test

    @jennybc
    jennybc committed May 5, 2018
    Configuration menu
    Copy the full SHA
    f698235 View commit details
    Browse the repository at this point in the history

Commits on May 11, 2018

  1. Extend test to xlsx

    @jennybc
    jennybc committed May 11, 2018
    Configuration menu
    Copy the full SHA
    96cd855 View commit details
    Browse the repository at this point in the history

  2. Don't modify xls path on the C++ side

    @jennybc
    jennybc committed May 11, 2018
    Configuration menu
    Copy the full SHA
    2afc45e View commit details
    Browse the repository at this point in the history

  3. Ensure all paths are in native encoding at the handoff

    @jennybc
    jennybc committed May 11, 2018
    Configuration menu
    Copy the full SHA
    098c3b0 View commit details
    Browse the repository at this point in the history

  4. Edit NEWS 

    [skip ci]
    @jennybc
    jennybc committed May 11, 2018
    Configuration menu
    Copy the full SHA
    a15391b View commit details
    Browse the repository at this point in the history