-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warning seen with sanitizers #769
Comments
gcc-san result from "specialChecks" on CRAN's incoming checks for a submission of (hopeful) readxl v1.4.4 Implicates the same loci in From
|
valgrind result seen in my recent PR updating libxls to v1.6.3 https://github.com/tidyverse/readxl/actions/runs/13274947484/job/37062619489 Suspect this is unrelated to the libxls out of bounds warnings Click to expand
|
gcc-asan result seen in a newly created container thanks to @gaborcsardi workflow file: https://github.com/gaborcsardi/readxl/blob/main/.github/workflows/rhub.yaml very similar to the gcc-UBSAN from CRAN for readxl v1.4.3 and gcc-san result from incoming CRAN checks on readxl v1.4.4 Key bits:
Click to expand, warning in `excel_sheets()` examples
Click to expand, warning from `test_check("readxl")`
|
I think this is a bug in libxls. Posted it here: libxls/libxls#144 (we fixed the same problem in mongo-c-driver last week) |
Yeah I already started investigating such a solution yesterday in this branch: https://github.com/tidyverse/readxl/compare/fix-sanitizer-warning. I made 1 interesting commit there (after faffing about with GHA) that made some of the warnings go away (it's coming from multiple locations). There is relevant history around readxl and libxls here: libxls/libxls#15. |
Ah sorry didn't mean to cross you! Seems like we found the same solution, which is a good sign :) |
Brief recap of some history, now that I've re-uploaded all of this into my head. I may or may not return to add more links to specific resources or refs.
|
Collecting various links and snippets to make this easier for me to analyze.
Now that v1.4.4 is on CRAN, there is a new deadline to address this issue: "Please correct before 2025-03-14 to safely retain your package on CRAN."
gcc-UBSAN result from CRAN's additional issues, pertaining to readxl v1.4.3
https://www.stats.ox.ac.uk/pub/bdr/memtests/gcc-UBSAN/readxl/
First instance reported in examples for
excel_sheets()
. Perhaps notably thegeometry.xls
sheet has been accessed earlier (in the examples for cell-specification) w/o issue. Not sure how much to read into where the warning appears in this output, though.Key bits:
Click to expand, readxl-Ex.Rout
Click to expand, testthat.Rout
The text was updated successfully, but these errors were encountered: