Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release readxl 1.4.4 #768

Closed
16 tasks done
jennybc opened this issue Feb 25, 2025 · 2 comments
Closed
16 tasks done

Release readxl 1.4.4 #768

jennybc opened this issue Feb 25, 2025 · 2 comments

Comments

@jennybc
Copy link
Member

jennybc commented Feb 25, 2025

Prepare for release:

  • git pull
  • Check current CRAN check results see below for some remarks
  • Polish NEWS
  • urlchecker::url_check()
  • devtools::build_readme()
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • revdepcheck::cloud_check()
  • Update cran-comments.md
  • git push

Submit to CRAN:

  • usethis::use_version('patch')
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted 🎉
  • usethis::use_github_release()
  • usethis::use_dev_version(push = TRUE)
@jennybc jennybc pinned this issue Feb 25, 2025
@jennybc
Copy link
Member Author

jennybc commented Feb 25, 2025

Discussing some CRAN results as of 2025-02-25


Version: 1.4.3
Check: Rd cross-references
Result: NOTE 
  Found the following Rd file(s) with Rd \link{} targets missing package
  anchors:
    cell-specification.Rd: cellranger
  Please provide package anchors for all Rd \link{} targets not in the
  package itself and the base packages.

Solved already in c7c6850.


Version: 1.4.3
Check: whether package can be installed
Result: WARN 
  Found the following significant warnings:
    /data/gannet/ripley/R/test-clang/cpp11/include/cpp11/R.hpp:52:31: warning: identifier '_xl' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
    /data/gannet/ripley/R/test-clang/cpp11/include/cpp11/named_arg.hpp:42:29: warning: identifier '_nm' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
  See ‘/data/gannet/ripley/R/packages/tests-clang/readxl.Rcheck/00install.out’ for details.
  * used C compiler: ‘clang version 20.1.0-rc2’
  * used C++ compiler: ‘clang version 20.1.0-rc2’

cpp11 issue r-lib/cpp11#447.


Version: 1.4.3
Check: compiled code
Result: NOTE 
  File ‘readxl/libs/readxl.so’:
    Found non-API calls to R: ‘Rf_StringFalse’, ‘Rf_StringTrue’
  
  Compiled code should not call non-API entry points in R.

Solved already in 4764967.

@jennybc
Copy link
Member Author

jennybc commented Feb 25, 2025

Discussing some CRAN results under "Additional issues" as of 2025-02-25:

@jennybc jennybc closed this as completed Feb 28, 2025
@jennybc jennybc unpinned this issue Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant