Use scales::label_* over scales::*format()`
#5504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teunbrand
approved these changes
Nov 2, 2023
Collaborator
teunbrand
left a comment
teunbrand
left a comment
There was a problem hiding this comment.
All these changes look good to me, thanks for the contribution!
teunbrand
added a commit
to teunbrand/ggplot2
that referenced
this pull request
Nov 8, 2023
teunbrand
added a commit
that referenced
this pull request
Dec 6, 2023
* set dotplot binwidth * set number of bins * fill in smooth defaults * silence coord replacements * stat_summary2d has been replace by stat_summary_2d * fill quantile formula * suppress scale type messages * suppress sp-related messages * use explicit tempfiles * Include snapshot renaming from #5504
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a period at the end of the
check_installed()messages for consistency. https://style.tidyverse.org/error-messages.html