check if axis is present before adding padding to facet_grid #4669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clauswilke
approved these changes
Nov 12, 2021
Member
clauswilke
left a comment
clauswilke
left a comment
There was a problem hiding this comment.
Looks good, but maybe add some sort of test?
teunbrand
added a commit
to teunbrand/ggplot2
that referenced
this pull request
May 30, 2024
teunbrand
added a commit
that referenced
this pull request
Jun 24, 2024
* isolate wrap panel initialisation * isolate wrap axis attachment * isolate wrap strip attachment * isolate grid panel initialisation * isolate grid axis attachment * isolate grid strip attachment * eliminate need for strips to know about axis size * make formals consistent * include all cases of grid strip/axis interactions in tests * use `seam_table()` helper * fix bug * remove duplicate test from #4669 * share init_gtable method * share majority of `draw_panels()` * add news bullet * Update snapshots for cli 3.6.3 * fix note
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4610
This PR adds the same type of check for presence of axis that happens in
facet_wrap()tofacet_grid()before adding padding between the strip and axis