Use systematic naming for geom_bin_2d(), just like geom_density_2d() #4449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Not sure why the text coverage fails. If anybody has an idea, please let me know. |
Member
Author
It helps to teach a semester-long course on this material and to try to get everything consistent in the slides. :-) |
Member
Sorry, it's my fault. #4454 will fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
geom_density_2d(), we have versions with and versions without underscore before the 2d. But forgeom_bin2d(), we don't currently have those, even though we do forgeom_stat_2d(). This PR fixes this, by addinggeom_bin_2d().