Create quosures in tally_n()
#7046
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
commented
Jul 10, 2024
| } else { | ||
| expr(sum(!!wt, na.rm = TRUE)) | ||
| new_quosure(expr(sum(!!wt, na.rm = TRUE)), quo_get_env(wt)) |
There was a problem hiding this comment.
This probably should be:
Suggested change
| new_quosure(expr(sum(!!wt, na.rm = TRUE)), quo_get_env(wt)) | |
| new_quosure(expr(sum(!!wt, na.rm = TRUE)), baseenv()) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent duckplyr checks that all functions used in a dplyr verb are what they pretend they are: tidyverse/duckplyr#179. This works for most cases, except for the
n()created bytally_n(). This PR fixes this.Once we agree on the implementation, I can vendor in a copy of this function into duckplyr.