Skip to content

Conversation

@romainfrancois
Copy link
Member

closes #5760

library(dplyr, warn.conflicts = FALSE)

m <- mtcars
attr(m, "foo") <- "a"
m <- dplyr::group_by(m, vs)
attr(m, "foo")
#> [1] "a"
m <- dplyr::group_by(m, cyl, .add = TRUE)
attr(m, "foo")
#> [1] "a"

Created on 2021-02-16 by the reprex package (v0.3.0)

ungroup() wipes all attributes, but dplyr_reconstruct() would restore @groups which we don't want. Not sure this can be abstracted away ?

@romainfrancois romainfrancois added this to the 1.0.5 milestone Feb 16, 2021
@romainfrancois romainfrancois force-pushed the group_by_keep_atts_5760 branch from 67c4119 to f9a5d94 Compare February 16, 2021 10:02
@romainfrancois romainfrancois merged commit ab439c4 into master Feb 17, 2021
@romainfrancois romainfrancois deleted the group_by_keep_atts_5760 branch February 17, 2021 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Using dplyr 1.0.4., plot with controls created by crosstalk and plotly is not interactive any more

3 participants