Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate across(, ...) #6073

Closed
romainfrancois opened this issue Nov 9, 2021 · 1 comment · Fixed by #6365
Closed

Deprecate across(, ...) #6073

romainfrancois opened this issue Nov 9, 2021 · 1 comment · Fixed by #6365
Labels
breaking change ☠️ API change likely to affect existing code each-col ↔️ lifecycle 🦋
Milestone
1.1.0

Comments

@romainfrancois
Copy link
Member

Passing extra arguments to .fns is hard to do right, and across() will be easier to reason about if it does not have to deal with ....
@romainfrancois romainfrancois added the breaking change ☠️ API change likely to affect existing code label Nov 9, 2021
@romainfrancois romainfrancois added this to the 1.1.0 milestone Nov 9, 2021
@eutwt eutwt mentioned this issue Feb 8, 2022
Merged
@mikkmart mikkmart mentioned this issue Mar 3, 2022
Closed
@krlmlr krlmlr mentioned this issue May 1, 2022
Closed
@DavisVaughan
Copy link
Member

Investigate if this fixes #6251 (comment) when we officially deprecate this and simplify across()

hadley added a commit that referenced this issue Jul 25, 2022
@hadley
Deprecate passing additional arguments in across
26e8360 
Fixes #6073
@hadley hadley mentioned this issue Jul 25, 2022
Merged
@hadley hadley closed this as completed in 0dd7eea Aug 3, 2022
@pwwang pwwang mentioned this issue Sep 4, 2023
Closed
12 tasks
john-h-watson added a commit to john-h-watson/r-collection that referenced this issue Nov 23, 2023
@john-h-watson
remove deprecated ... in across()
e06e8f1 
passing additional arguments to round function using lambda. Using ... is deprecated  (see https://dplyr.tidyverse.org/news/index.html#newly-deprecated-1-1-0 and tidyverse/dplyr#6073)
@john-h-watson john-h-watson mentioned this issue Nov 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change ☠️ API change likely to affect existing code each-col ↔️ lifecycle 🦋
Projects
None yet
Milestone
1.1.0
Development

Successfully merging a pull request may close this issue.

Deprecate passing additional arguments in across tidyverse/dplyr
3 participants
@hadley @romainfrancois @DavisVaughan