Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't call all_calls() and all_names() recursively #1582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

EmilHvitfeldt
Copy link

@EmilHvitfeldt EmilHvitfeldt commented Feb 10, 2025

Since all_calls() and all_names() are run recursively, they complain about longer expressions. This PR rewrites them with the base functions all.names() and all.vars() to avoid this problem

Before This PR

Screenshot 2025-02-10 at 10 57 27 AM

With this PR

long <- rlang::parse_quo(paste(rep(letters, 50), collapse = " + "), env = globalenv())

dbplyr:::all_names(long)
#>  [1] "a" "b" "c" "d" "e" "f" "g" "h" "i" "j" "k" "l" "m" "n" "o" "p" "q" "r" "s"
#> [20] "t" "u" "v" "w" "x" "y" "z"
dbplyr:::all_calls(long)
#> [1] "+"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant