use type checkers in backend-*.R files
#1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just confirmed that the |
hadley
approved these changes
Nov 6, 2024
| @@ -333,6 +335,7 @@ simulate_mssql <- function(version = "15.0") { | |||
| second = function(x) sql_expr(DATEPART(SECOND, !!x)), | |||
|
|
|||
| month = function(x, label = FALSE, abbr = TRUE) { | |||
| check_bool(label) | |||
There was a problem hiding this comment.
I'd be tempted to move the check for check_unsupported_arg() next to this check.
There was a problem hiding this comment.
Oh, interesting. I moved that check_unsupported_arg() call to be evaluated unconditionally before realizing that the only allowed value for abbr is FALSE and the default is TRUE. Bringing the check out of if (label) would mean that month(x) would fail by default on SQL server. I opted not to make your suggested change here and will leave this as unresolved for a day or two to give you a chance to reply before merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1555. As in #1554, didn't apply checks to arguments that are passed directly to
sql_*()functions.