Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tile38_expired_keys is never returned #717

Closed
undeadcat opened this issue Feb 12, 2024 · 0 comments · Fixed by #718
Closed

tile38_expired_keys is never returned #717

undeadcat opened this issue Feb 12, 2024 · 0 comments · Fixed by #718

Comments

@undeadcat
Copy link
Contributor

undeadcat commented Feb 12, 2024

Describe the bug
The metric for expired keys (tile38_expired_keys) is never returned from metrics endpoint

To Reproduce
Tile38 version: 1.32.1

  1. run tile38 with Prometheus metrics, e.g ./tile38-server --metrics-addr localhost:1234
  2. Set several keys with expiration, e.g. SET fleet truck POINT 33.5123 -112.2693 EX 1
  3. Wait 1s for keys to expire, call metrics endpoint: http://localhost:1234/metrics

Expected behavior
Expect metrics to conain tile38_expired_keys, bit it doesn't

** Additional**
Created a PR mostly to illustrate what I understand the issue to be: #718
Feel free to close and /or redo if you prefer :-)

undeadcat added a commit to undeadcat/tile38 that referenced this issue Feb 12, 2024
expired_keys never incremented
additional metrics not returned from metrics endpoint
tidwall added a commit that referenced this issue Feb 15, 2024
…rned

fix #717: tile38_expired_keys and several other metrics not returned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant