Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(android): tableview content update fix #14169

Closed
wants to merge 1 commit into from
Closed

fix(android): tableview content update fix #14169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion android/modules/ui/src/java/ti/modules/titanium/ui/TableViewProxy.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,8 +189,10 @@ private void appendRowInternal(Object rows, KrollDict animation, boolean interna
row.getProperties().optString(TiC.PROPERTY_FOOTER_TITLE,
row.getProperties().getString(TiC.PROPERTY_FOOTER)));

if (row.getParent() != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this conditional code as it would cause more issues because it's changing the parent-section of a row from one to another without properly removing the row from its previous parent-section first.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then we have the same code as before and it won't behave the same way it did in 12.5.1 where you were able to set content without running update. Can you create a PR with a proper solution for both cases

row.setParent(section);
}
// Add row to section.
row.setParent(section);
section.add(row);
}

Expand Down
Loading