adapts sarama.Logger to implement log.Logger #744
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewollesen
force-pushed
the
eric-cpa-alerts7
branch
from
b8576cd
to
e03828d
Compare
ewollesen
force-pushed
the
eric-cpa-alerts8
branch
from
5460ab6
to
31d2295
Compare
ewollesen
force-pushed
the
eric-cpa-alerts7
branch
from
e03828d
to
1d72b9b
Compare
ewollesen
force-pushed
the
eric-cpa-alerts8
branch
from
31d2295
to
8f80817
Compare
So that sarama log messages better follow our standards, and will be emitted as JSON when log.Logger is configured for that. Before this change, the sarama logs were printed in plain-text without any of the benefits of the platform log.Logger. BACK-2554
ewollesen
force-pushed
the
eric-cpa-alerts8
branch
from
8f80817
to
c0d9c32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that sarama log messages better follow our standards, and will be emitted as JSON when log.Logger is configured for that.
Before this change, the sarama logs were printed in plain-text without any of the benefits of the platform log.Logger.
BACK-2554