Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACK-2963] Standard Deviation and other new CGM stats #713

Merged
merged 13 commits into from
Jul 10, 2024
Merged

[BACK-2963] Standard Deviation and other new CGM stats #713

merged 13 commits into from
Jul 10, 2024

Conversation

Roukoswarf
Copy link
Contributor

No description provided.

ewollesen
ewollesen reviewed Apr 29, 2024
View reviewed changes
data/summary/types/cgm.go Outdated Show resolved Hide resolved
data/summary/types/cgm.go Outdated Show resolved Hide resolved
data/summary/types/cgm.go Show resolved Hide resolved
ewollesen
ewollesen requested changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@ewollesen ewollesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly nits. I do think that the SD/CV should be expanded though.

data/summary/types/cgm.go Show resolved Hide resolved
data/summary/types/cgm.go Show resolved Hide resolved
data/summary/types/cgm.go Outdated Show resolved Hide resolved
data/summary/types/cgm.go Outdated Show resolved Hide resolved
data/summary/types/cgm_test.go Outdated Show resolved Hide resolved
data/summary/types/cgm_test.go Outdated Show resolved Hide resolved
data/summary/types/cgm_test.go Outdated Show resolved Hide resolved
ewollesen
ewollesen previously approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@ewollesen ewollesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Alex!

data/summary/types/cgm.go Show resolved Hide resolved
data/summary/types/cgm_test.go Outdated Show resolved Hide resolved
Base automatically changed from realtimeRecords to master June 13, 2024 17:56
@Roukoswarf Roukoswarf dismissed ewollesen’s stale review June 13, 2024 17:56

The base branch was changed.

@Roukoswarf
Add to CGM Summary Stats:
bfe7326 
 - Standard Deviation
 - Coefficient of Variation
 - Hours With Data
 - Days With Data
 - Time In Extreme High Minutes, Records, Percent

Add to BGM Summary Stats:
  - Time In Extreme High Records, Percent
@Roukoswarf
update deps
e75315a
@Roukoswarf Roukoswarf force-pushed the alex/back-2963-additional-cgm-stats branch from 8b18faf to e75315a Compare June 18, 2024 20:51
@Roukoswarf
Copy link
Contributor Author

/deploy qa2

@tidebot
Copy link
Collaborator

tidebot commented Jun 18, 2024

Roukoswarf updated values.yaml file in qa2

@tidebot
Copy link
Collaborator

tidebot commented Jun 18, 2024

Roukoswarf updated flux policies file in qa2

@tidebot
Copy link
Collaborator

tidebot commented Jun 18, 2024

Roukoswarf deployed platform alex/back-2963-additional-cgm-stats branch to qa2 namespace

ewollesen
ewollesen requested changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@ewollesen ewollesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one question around a TODO comment and some commented out code.

data/summary/types/bgm_test.go Outdated Show resolved Hide resolved
@Roukoswarf Roukoswarf merged commit cb755f2 into master Jul 10, 2024
2 checks passed
@Roukoswarf Roukoswarf deleted the alex/back-2963-additional-cgm-stats branch July 10, 2024 02:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toddkazakov toddkazakov toddkazakov left review comments

@ewollesen ewollesen ewollesen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@Roukoswarf @tidebot @ewollesen @toddkazakov