Change the readonly detection for TiddlyWiki Classic #339
+29
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This rolls back the behavior change from #328, but provides a way to bring it back if you prefer it, by setting up a window.bidix object in another tiddler tagged with "systemConfig". As mentioned in the comments, the motivation for doing this is that hiding the "upload to tiddlyhost" button causes usability problems for TW classic users.
simonbaird
force-pushed
the
change-readonly-detection-for-classic
branch
from
01373bc to
26ed8fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rolls back the behavior change from #328, but provides a way to bring it back if you prefer it.
As mentioned in the comments, the motivation for doing this is that hiding the "upload to tiddlyhost" button causes usability problems for TW classic users.
FYI @YakovL.