Put saver support and etag checking to prevent overwrites #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonbaird
force-pushed
the
put-saver
branch
2 times, most recently
from
3cde18c to
efaf49b
Compare
|
I think this depends on TiddlyWiki/TiddlyWiki5#6589 , otherwise Tiddlyhost isn't able to get any failure messages through to users. |
simonbaird
changed the title
simonbaird
changed the title
|
It works pretty well for me locally with an empty file based on TiddlyWiki/TiddlyWiki5#6589 . If that gets merged, then I'll deploy this to prod, and suggest it can be used with a TW 5.2.3 prerelease. |
simonbaird
force-pushed
the
put-saver
branch
3 times, most recently
from
ef64818 to
7500ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's some new stuff compared to the older POC from #148.