Reduce compilation warnings #128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/common.h: In constructor 'BaseEvent::BaseEvent(SCRef, int)': src/common.h:448: warning: declaration of 'd' shadows a member of 'BaseEvent' /usr/include/qt5/QtCore/qcoreevent.h:313: note: shadowed declaration is here src/common.h: In constructor 'MessageEvent::MessageEvent(SCRef)': src/common.h:455: warning: declaration of 'd' shadows a member of 'MessageEvent' src/common.h:457: note: in expansion of macro 'DEF_EVENT'
|
Hello Jonathan For my instruction, please describe in some detail your compilation setup. I have the latest gcc (gcc-12) available for my distro, I have the compiler debug flags set to I can only see the warnings you fix with your last commit. I can understand from the code the fixes in the 2nd and 3rd commit (although I would like to also get the warnings locally, so please help me with the config). And I don't see any reasons in the code for the 1st and 4th commit. Thanks in advance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They do not affect the code, but give lots of diagnostic messages when compiled with -W -Wall -Wextra. The changes remove them so that other messages warning of potential problems will not be lost among the noise.
The wanings eliminated are:
"declaration shadows a member"
"use of old-style cast"
"can be marked override"
"declaration shadows a parameter"
"declaration shadows a previous local"
"implictly-declared (constructor) is deprecated"