Ubuntu import 1.0-rc93 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runc now has special handling for seccomp profiles to avoid making new syscalls unusable for glibc (LP: #1916485).
|
Weird, it does not FTBFS on armhf in Debian: |
|
(otherwise this looks very benign to me, assuming it works with containerd and Docker 👍) |
lucaskanashiro
force-pushed
the
ubuntu-import-1.0-rc93
branch
from
197a7a5 to
ffe93bf
Compare
|
Thanks @tianon . I backported the same patch and it fixed the issue. I do not know why I did not see this patch before 🤦 I am testing everything using the PPA in the description (there you can find docker.io and containerd packages as well), I am going to wait for your +1 to move forward. |
|
Thanks! I am just waiting for the FFe approval to get it merged and uploaded. |
|
FFe was approved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 1.0.0~rc93 contains an important fix for this bug:
https://bugs.launchpad.net/ubuntu/+source/glibc/+bug/1916485
I uploaded the package to this PPA:
https://launchpad.net/~lucaskanashiro/+archive/ubuntu/docker-20.10/+packages
As you can see it FTBFS on armhf, there is an integer overflow in the test of the fix we want. I filed an upstream bug here:
opencontainers/runc#2846
I considered to skip this test for now, but since the failing test is seccomp related, which we want to make sure it is working, I turned it down. Let me know if you have a better approach for this issue.
FWIW autopkgtest is still happy on amd64: