MdePkg: Improving readability of CVE patch for PeCoffLoaderRelocateImage #6264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tianocore-assign-reviewers
bot
requested review from
lgao4,
LiuZhiguang001 and
mdkinney
Flickdm
force-pushed
the
security-advisory/cve-2024-38796/advisory
branch
from
d0904de
to
ae0ca03
Compare
mdkinney
approved these changes
Sep 30, 2024
This change adds parantheses to the if condition detecting overflow in
the PeCoffLoaderRelocateImage function to improve readability.
Follow on change for:
REF!: tianocore#6249
Signed-off-by: Doug Flick <[email protected]>
Flickdm
force-pushed
the
security-advisory/cve-2024-38796/advisory
branch
from
ae0ca03
to
7eb5a9e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds parantheses to the if condition detecting overflow in the PeCoffLoaderRelocateImage function to improve readability.
Follow on change for:
REF!: #6249
Breaking change?
Impacts security?
Includes tests?
How This Was Tested
Booted Locally