UefiPayloadPkg: fix output dir name generation in .dsc #6262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can only assume this has only been tested in environments where for some reason BUILD_ARCH is set for reasons unrelated to the EDK2 build system. When attempting to build directly, I ended up with a directory 'UefiPayloadPkg$(BUILD_ARCH)' created and the build immediately failing. Change the .dsc to use ARCH instead, which *is* set by the build system. Signed-off-by: Leif Lindholm <[email protected]>
tianocore-assign-reviewers
bot
requested review from
gdong1,
gguo11837463,
jameslu8 and
Sean-StarLabs
|
OK, so the cure is as bad as the disease. I'll need to ponder this one for a while. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can only assume this has only been tested in environments where for some reason BUILD_ARCH is set for reasons unrelated to the EDK2 build system. When attempting to build directly, I ended up with a directory 'UefiPayloadPkg$(BUILD_ARCH)' created and the build immediately failing.
Change the .dsc to use ARCH instead, which is set by the build system.
I don't know the situation in which the existing setup could work, so I'm unsure whether this change affects any build-time behaviours there.