Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test #6245

Draft
wants to merge 15 commits into
base: master
Choose a base branch
from
Draft

Test #6245

wants to merge 15 commits into from

Conversation

sunceping
Copy link
Contributor

Description

<Include a description of the change and why this change was made.>

<For each item, place an "x" in between [ and ] if true. Example: [x] (you can also check items in GitHub UI)>

<Create the PR as a Draft PR if it is only created to run CI checks.>

<Delete lines in <> tags before creating the PR.>

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

<Describe the test(s) that were run to verify the changes.>

Integration Instructions

<Describe how these changes should be integrated. Use N/A if nothing is required.>

Signed-off-by: Min Xu <[email protected]>
Signed-off-by: Ceping Sun <[email protected]>
Signed-off-by: Min Xu <[email protected]>
Signed-off-by: Ceping Sun <[email protected]>
Since TDVF have to measure fw_cfg data from QEMU,
it is reqiured to cache the data with measurement
in early phase, that can avoid changing the measurement
order when reading the fw_cfg process, which depends
on multipe factors(depex, order in the firmware volume).

Cc: Erdem Aktas <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Min Xu <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Elena Reshetova <[email protected]>
Signed-off-by: Ceping Sun <[email protected]>
Since the TdxHelperLib is used for measurement
in PEI phase, it required TDVF to add the library.
And for other platform, it is null.

Cc: Erdem Aktas <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Min Xu <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Elena Reshetova <[email protected]>
Signed-off-by: Ceping Sun <[email protected]>
OVMF uses FW_CFG_SELECTOR(0x510) and FW_CFG_IO_DATA(0x511) to
get configuration infomation from QEMU. From the security perspective
these information shall be measured before they're consumed.

This patch reads the fw_cfg items and cached them in a GuidHob. In the
meanwhile these fw_cfg items are measured as well. This is to avoid
changing the order when  reading the fw_cfg process, which depends on
multiple factors(depex, order in  the Firmware volume).

Signed-off-by: Min Xu <[email protected]>
Signed-off-by: Ceping Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant