Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MdePkg: Create Google Test mock for MpService Protocol #6233

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

v-chhsieh
Copy link

Description

This patch creates a gmock for the MpService function, which is used by CI testing.

  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Unit tests component can call these mock functions success.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:testing This contribution includes tests such as unit and/or integration tests. label Sep 24, 2024
@shrugupt
Copy link

@lgao4 @mdkinney @LiuZhiguang001 Could you please help review this PR.

@lgao4
Copy link
Contributor

lgao4 commented Sep 30, 2024

I think two commits can be combined into one, and the commit should just describe what is changed, don't need to mention it is used your project.

Add mock protocol for Google Test used

Signed-off-by: Jack Hsieh <[email protected]>
@v-chhsieh
Copy link
Author

I've finished the comment combined.

@shrugupt
Copy link

shrugupt commented Oct 1, 2024

@lgao4 Kindly help review the latest uploaded code changes. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:testing This contribution includes tests such as unit and/or integration tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants