UefiCpuPkg: RISC-V: Initialize FPU

[xypron]

Description

EDK II build with TLS running on top of QEMU/KVM crashes when reaching the first floating point instruction in the OpenSSL library (https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/2036604). This is due to the floating point unit being in an disabled state (FS bit-field in CSR mstatus).

With the series a library module BaseRiscVFpuLib is added. Here the relevant CSRs are initialized.
In future we can add here the initialization of the vector unit once any library uses it.

How This Was Tested

Running with QEMU/KVM on SiFive HiFive Premier.

Integration Instructions

N/A

[vlsunil]

Hi Heinrich,
Thank you very much for the PR. The changes look good to me. However, please fix CI issues like adding to spellcheck ignore list.

[xypron]

@vlsunil:
Thank you for reviewing.
There are some issues that I should fix. E.g PatchCheck.py does not like changing two packages with the same patch.
But spellcheck (in https://dev.azure.com/tianocore/11ea4a10-ac9f-4e5f-8b13-7def1f19d478/_apis/build/builds/150553/logs/312) complains about words that are not in my patches, e.g. 'abvoe' in

UefiCpuPkg/Library/MpInitLib/MpLib.c:952:
@param[out] SizeAbove1Mb Return the size of abvoe 1MB memory for AP reset area.

[xypron]

For #6210 I get this test result:
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=151342&view=ms.vss-test-web.build-test-results-tab&runId=1394573&resultId=100012&paneView=debug
How can I find out what file CI is complaining about?
When I run uncrustify locally I do not see any error except parsing errors for EmbeddedPkg and BaseTools, which I did not touch in my PR.

[leiflindholm]

Hi Heinrich, Thank you very much for the PR. The changes look good to me. However, please fix CI issues like adding to spellcheck ignore list.

@vlsunil The spellchecker is in audit mode, so that's not the failure, just noise.
The failure is in uncrustify, but I can't figure out what it's upset about...

@makubacki can you help figure out what's going on?

[makubacki]

@makubacki can you help figure out what's going on?

1. If you go to the link provided in xypron's earlier comment - https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=151342&view=ms.vss-test-web.build-test-results-tab&runId=1394573&resultId=100012&paneView=debug.

2. Click "Attachments".

   

3. Click "Standard_Error_Output.log".

   

4. There you will see a diff showing what needs to be done:

Uncrustify found 1 files with formatting errors:
Formatting errors in Include\Register\RiscV64\RiscVEncoding.h

--- D:\a\1\s\MdePkg\Include\Register\RiscV64\RiscVEncoding.h
+++ D:\a\1\s\MdePkg\Include\Register\RiscV64\RiscVEncoding.h.uncrustify_plugin
@@ -78,7 +78,7 @@
#define CSR_TIME   0xc01

/* Floating-Point */
-#define CSR_FCSR     0x003
+#define CSR_FCSR  0x003

/* Supervisor Trap Setup */
#define CSR_SSTATUS  0x100

---

That said, I will take this an opportunity to add the information directly to the build output. That was avoided early on due to concern about the larger number of errors while the codebase was in transition. Now, I think it's obvious placing this information front and center would be more efficient to resolve the problem.

[xypron]

@makubacki: Thanks for pointing me to the right attachment.

Looking at https://tianocore-docs.github.io/edk2-CCodingStandardsSpecification/draft/5_source_files/52_spacing.html#52-spacing I would not know which rule I have broken.

Does the CI assume that all files are formatted via

uncrustify -c .pytool/Plugin/UncrustifyCheck/uncrustify.cfg -f

even if they don't break any rule in https://tianocore-docs.github.io/edk2-CCodingStandardsSpecification?

[vlsunil]

Thanks! @makubacki for the help!. Thanks @xypron for fixing the CI issue. I always run uncrustify locally using the edk2's config but you have a good point on documentation vs uncrustify expectations. May be @makubacki or @mdkinney can help clarify.

Since major changes are in MdePkg and UefiPkg, need help from @mdkinney and @niruiyu to review and merge this PR.

[makubacki]

Does the CI assume that all files are formatted via

uncrustify -c .pytool/Plugin/UncrustifyCheck/uncrustify.cfg -f

even if they don't break any rule in https://tianocore-docs.github.io/edk2-CCodingStandardsSpecification?

Yes. There was much deliberation, that ultimately led to the decision to apply consistency to elements like alignment and spacing that were too tedious to include in the specification.

Many IDEs have a way to run an external tool with additional context. I personally use VS Code with the uncrustify plugin as described here: EDK II Code Formatting - Recommended Usage: Visual Studio (VS) Code Plugin. I stage or commit the file with actual modifications and then use a keyboard shortcut to run uncrustify on the current file. After a comparison to see what changed, I add the changes to the staging area or amend my commit.

[vlsunil]

@mdkinney @niruiyu - Let me know if you have any feedback on this PR. I plan to merge this in next couple of days if no objection.