Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update how importlib is imported #825

Merged
merged 2 commits into from
Jun 5, 2024
Merged

Update how importlib is imported #825

merged 2 commits into from
Jun 5, 2024

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented Jun 4, 2024

edk2-pytool-library is failing to update on edk2 due to an importlib issue on edk2-pytool-extensions (see: https://github.com/tianocore/edk2/actions/runs/9368163753/job/25789491929?pr=5722). From a google search, the issue is that we should be importing as import importlib.util not import importlib: https://stackoverflow.com/questions/66797668/module-importlib-has-no-attribute-util

@Javagedes Javagedes requested review from apop5 and makubacki June 5, 2024 01:58
@Javagedes Javagedes marked this pull request as ready for review June 5, 2024 01:58
@Javagedes Javagedes added the bug Something isn't working label Jun 5, 2024
@Javagedes Javagedes added this to the 0.27.6 milestone Jun 5, 2024
@Javagedes Javagedes self-assigned this Jun 5, 2024
@Javagedes Javagedes merged commit 59bc32c into master Jun 5, 2024
23 checks passed
@Javagedes Javagedes deleted the update-importlib branch June 5, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants