edk2_logging: bugfix invalid logging config set #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an invalid logging config was set because a log message was registered before the logging was set to edk2 requirements. When this happens, a basic config is applied, which causes other configs not to be applied.
cfernald
approved these changes
Jun 7, 2023
apop5
approved these changes
Jun 7, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #587 +/- ##
==========================================
+ Coverage 78.94% 78.99% +0.04%
==========================================
Files 47 47
Lines 4778 4774 -4
==========================================
- Hits 3772 3771 -1
+ Misses 1006 1003 -3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an invalid logging config was set because a log message was registered before the logging was set to edk2 requirements. When this happens, a basic config is applied, which causes other configs not to be applied.
closes #586