uefi_helper_plugin.py: Log plugin load exception message at error level #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logs the message at error level so it is more likely to be seen by the user in their console so they know what to do. Before: ``` > stuart_update -c .\Platforms\QemuQ35Pkg\PlatformBuild.py TOOL_CHAIN_TAG=VS2022 SECTION - Init Self Describing Environment SECTION - Loading Plugins WARNING - Unable to register Supervisor Policy Maker Traceback (most recent call last): ... Exception: One or more helper plugins failed to load. ``` After: ``` > stuart_update -c .\Platforms\QemuQ35Pkg\PlatformBuild.py TOOL_CHAIN_TAG=VS2022 SECTION - Init Self Describing Environment SECTION - Loading Plugins WARNING - Unable to register Supervisor Policy Maker ERROR - Function MakeSupervisorPolicy already registered from plugin file D:\src\mu_tiano_platforms\Features\MM_SUPV\MmSupervisorPkg\SupervisorPolicyTools\SupervisorPolicyMaker.py. Can't register again from D:\src\mu_tiano_platforms\Features\MM_SUPV_Redundant\MmSupervisorPkg\SupervisorPolicyTools\SupervisorPolicyMaker.py ``` Signed-off-by: Michael Kubacki <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #561 +/- ##
=======================================
Coverage 78.49% 78.49%
=======================================
Files 47 47
Lines 4767 4767
=======================================
Hits 3742 3742
Misses 1025 1025
|
Javagedes
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs the message at error level so it is more likely to be seen by the user in their console so they know what to do.
Before:
After: