Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edk2_logging: add gcc fatal error regex #547

Merged
merged 1 commit into from
May 17, 2023

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented May 12, 2023

Adds a regex that detects fatal error in the compiler output and logs the line as an error.

Example:
BrotliCompress.c:20:10: fatal error: ./brotli/c/common/constants.h: No such file or directory

@Javagedes Javagedes added the enhancement New feature or request label May 12, 2023
@Javagedes Javagedes added this to the 0.23.3 milestone May 12, 2023
@Javagedes Javagedes requested a review from makubacki May 12, 2023 18:34
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #547 (2be300f) into master (b42ef3d) will increase coverage by 0.20%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #547      +/-   ##
==========================================
+ Coverage   78.29%   78.49%   +0.20%     
==========================================
  Files          47       47              
  Lines        4763     4767       +4     
==========================================
+ Hits         3729     3742      +13     
+ Misses       1034     1025       -9     
Impacted Files Coverage Δ
edk2toolext/edk2_logging.py 87.79% <100.00%> (+0.29%) ⬆️

... and 3 files with indirect coverage changes

@makubacki
Copy link
Member

@Javagedes, we discussed some more fundamental changes to the regular expressions. I assume you're going to complete this PR as-is and do that separately? I think it makes sense to go ahead and get this into a smaller release before that.

@Javagedes
Copy link
Contributor Author

@Javagedes, we discussed some more fundamental changes to the regular expressions. I assume you're going to complete this PR as-is and do that separately? I think it makes sense to go ahead and get this into a smaller release before that.

Yes I'll merge this in a small release then work on a rework later.

@Javagedes Javagedes merged commit ee1b117 into tianocore:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants