Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition to Ruff [REBASE&FF] #524

Merged
merged 2 commits into from
May 9, 2023
Merged

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented May 5, 2023

Switch from flake8 and pydocstyle to ruff.

Will add additional ruff rules in future commits, but to reduce massive changes all at once, the bare minimum is introduced now.

Ruff allows for setting many more requirements then flake8 or pydocstyle alone. While this PR only introduces rules to match that of flake8 + ruff, additional rules will be added in future PRs.

@Javagedes Javagedes changed the title transition to ruff Transition to Ruff [REBASE&FF] May 5, 2023
@codecov
Copy link

codecov bot commented May 5, 2023

Codecov Report

Merging #524 (ef836fd) into master (4ef86af) will not change coverage.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #524   +/-   ##
=======================================
  Coverage   78.53%   78.53%           
=======================================
  Files          47       47           
  Lines        4766     4766           
=======================================
  Hits         3743     3743           
  Misses       1023     1023           
Impacted Files Coverage Δ
edk2toolext/environment/multiple_workspace.py 37.87% <ø> (ø)
edk2toolext/windows/secureboot/secureboot_audit.py 61.79% <ø> (ø)
edk2toolext/image_validation.py 76.84% <50.00%> (ø)

@Javagedes Javagedes marked this pull request as ready for review May 8, 2023 15:09
@Javagedes Javagedes marked this pull request as draft May 8, 2023 15:09
@Javagedes Javagedes force-pushed the ruff branch 2 times, most recently from bbc55c0 to f8513c0 Compare May 8, 2023 16:55
@Javagedes Javagedes marked this pull request as ready for review May 8, 2023 16:56
@Javagedes Javagedes added the enhancement New feature or request label May 8, 2023
@Javagedes Javagedes added this to the 0.23.2 milestone May 8, 2023
@Javagedes Javagedes modified the milestones: 0.23.2, 0.23.3 May 8, 2023
@Javagedes Javagedes self-assigned this May 9, 2023
Removes flake8 and pydocstyle, relying on ruff instead.
@Javagedes Javagedes merged commit 1b85322 into tianocore:master May 9, 2023
@Javagedes Javagedes deleted the ruff branch May 9, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants