repo_resolver: add git version Check #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apop5
approved these changes
Mar 31, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #486 +/- ##
=======================================
Coverage 79.38% 79.39%
=======================================
Files 45 45
Lines 4541 4543 +2
=======================================
+ Hits 3605 3607 +2
Misses 936 936
|
makubacki
approved these changes
Mar 31, 2023
Javagedes
added a commit
to Javagedes/edk2-pytool-extensions
that referenced
this pull request
Apr 14, 2023
Previously, the git version only mattered to edk2_setup, so the check was appropriate there. Now that the git version matters to much of the build system due to it's use of the -z flag when reading git worktrees, the check needed to be moved to a more appropriate place. This commit moves it from edk2_setup to repo_resolver.py:get_details()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the git version only mattered to edk2_setup, so the check was appropriate there. Now that the git version matters to much of the build system due to it's use of the
-zflag when reading git worktrees, the check needed to be moved to a more appropriate place. This commit moves it from edk2_setup to repo_resolver.py:get_details()New Error Message:
