Fixed setup --force when submodules don't exist #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
==========================================
- Coverage 79.42% 79.32% -0.10%
==========================================
Files 45 45
Lines 4519 4532 +13
==========================================
+ Hits 3589 3595 +6
- Misses 930 937 +7
|
Javagedes
reviewed
Mar 7, 2023
Updates an unrealistic test to be realistic and make the appropriate exception handling changes to pass the test as expected.
Javagedes
approved these changes
Mar 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
stuart_setupwas called with the--forceoption when the submodules aren't initialized (either new clone or they were deinit'd), the setup would fail. This fixes that problem.