Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cryptography requirement to at least 39.0.1 #459

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented Mar 3, 2023

Older versions of Cryptography are vulnerable to CVE-2023-0286, which is due to the fact that earlier versions bundle a pre-compiled version of openssl that has a known vulnerability noted in https://www.openssl.org/news/secadv/20230207.txt and https://www.openssl.org/news/secadv/20221213.txt.

Previously, the cryptography package version was downloaded from pyopenssl, however it is best that we specify the version ourselfs.

@Javagedes Javagedes added the bug Something isn't working label Mar 3, 2023
@Javagedes Javagedes added this to the 0.22.2 milestone Mar 3, 2023
@Javagedes Javagedes self-assigned this Mar 3, 2023
Older versions of Cryptography are vulnerable to CVE-2023-0286, which
is due to the fact that earlier versions bundle a pre-compiled version
of openssl that has a known vulnerability noted in
https://www.openssl.org/news/secadv/20230207.txt and
https://www.openssl.org/news/secadv/20221213.txt.

Previously, the cyrpography package version was downloaded from,
pyopenssl, however it is best that we specify the version ourselfs.

Signed-off-by: Joey Vagedes <[email protected]>
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #459 (58a998d) into master (ffc7f6f) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #459      +/-   ##
==========================================
- Coverage   79.42%   79.34%   -0.08%     
==========================================
  Files          45       45              
  Lines        4519     4517       -2     
==========================================
- Hits         3589     3584       -5     
- Misses        930      933       +3     
Impacted Files Coverage Δ
...2toolext/environment/extdeptypes/git_dependency.py 98.43% <100.00%> (ø)
edk2toolext/edk2_invocable.py 73.41% <0.00%> (-1.27%) ⬇️
edk2toolext/capsule/pyopenssl_signer.py 70.27% <0.00%> (-0.79%) ⬇️
...oolext/environment/extdeptypes/nuget_dependency.py 91.78% <0.00%> (-0.69%) ⬇️
edk2toolext/nuget_publishing.py 84.98% <0.00%> (-0.04%) ⬇️

@Javagedes Javagedes merged commit 5091beb into tianocore:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants