Skip to content

manager: fix button issues in module cards #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

manager: fix button issues in module cards #2719

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
86 changes: 41 additions & 45 deletions manager/app/src/main/java/me/weishu/kernelsu/ui/screen/Module.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,50 +695,50 @@ fun ModuleItem(
color = colorScheme.outline.copy(alpha = 0.5f)
)

Row(
modifier = Modifier,
horizontalArrangement = Arrangement.spacedBy(16.dp),
verticalAlignment = Alignment.CenterVertically
) {
Row {
AnimatedVisibility(
visible = module.enabled && !module.remove,
enter = fadeIn(),
exit = fadeOut(),
) {
if (module.hasActionScript) {
IconButton(
backgroundColor = colorScheme.secondaryContainer.copy(alpha = 0.8f),
minHeight = 35.dp,
minWidth = 35.dp,
onClick = {
navigator.navigate(ExecuteModuleActionScreenDestination(module.id)) {
launchSingleTop = true
}
viewModel.markNeedRefresh()
},
) {
Icon(
modifier = Modifier.size(20.dp),
imageVector = Icons.Rounded.PlayArrow,
tint = colorScheme.onSurface.copy(alpha = if (isSystemInDarkTheme()) 0.7f else 0.9f),
contentDescription = stringResource(R.string.action)
)
Row(
horizontalArrangement = Arrangement.spacedBy(12.dp)
) {
if (module.hasActionScript) {
IconButton(
backgroundColor = colorScheme.secondaryContainer.copy(alpha = 0.8f),
minHeight = 35.dp,
minWidth = 35.dp,
onClick = {
navigator.navigate(ExecuteModuleActionScreenDestination(module.id)) {
launchSingleTop = true
}
viewModel.markNeedRefresh()
},
) {
Icon(
modifier = Modifier.size(20.dp),
imageVector = Icons.Rounded.PlayArrow,
tint = colorScheme.onSurface.copy(alpha = if (isSystemInDarkTheme()) 0.7f else 0.9f),
contentDescription = stringResource(R.string.action)
)
}
}
}

if (module.hasWebUi) {
IconButton(
backgroundColor = colorScheme.secondaryContainer.copy(alpha = 0.8f),
minHeight = 35.dp,
minWidth = 35.dp,
onClick = { onClick(module) },
) {
Icon(
modifier = Modifier.size(20.dp),
imageVector = Icons.Rounded.Code,
tint = colorScheme.onSurface.copy(alpha = if (isSystemInDarkTheme()) 0.7f else 0.9f),
contentDescription = stringResource(R.string.open)
)
if (module.hasWebUi) {
IconButton(
backgroundColor = colorScheme.secondaryContainer.copy(alpha = 0.8f),
minHeight = 35.dp,
minWidth = 35.dp,
onClick = { onClick(module) },
) {
Icon(
modifier = Modifier.size(20.dp),
imageVector = Icons.Rounded.Code,
tint = colorScheme.onSurface.copy(alpha = if (isSystemInDarkTheme()) 0.7f else 0.9f),
contentDescription = stringResource(R.string.open)
)
}
}
}
}
Expand All @@ -747,20 +747,15 @@ fun ModuleItem(

if (updateUrl.isNotEmpty()) {
IconButton(
modifier = Modifier.padding(end = 16.dp),
backgroundColor = Color(if (isSystemInDarkTheme()) 0xFF25354E else 0xFFEAF2FF),
enabled = !module.remove,
minHeight = 35.dp,
minWidth = 35.dp,
onClick = { onUpdate(module) },
) {
Row(
modifier = Modifier.then(
if (updateUrl.isNotEmpty()) {
Modifier.padding(horizontal = 10.dp)
} else {
Modifier
}
),
modifier = Modifier.padding(horizontal = 10.dp),
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(2.dp),
) {
Expand All @@ -771,10 +766,11 @@ fun ModuleItem(
contentDescription = stringResource(R.string.module_update),
)
Text(
modifier = Modifier.padding(end = 3.dp),
text = stringResource(R.string.module_update),
color = Color(0xFF0D84FF),
fontWeight = FontWeight.Medium,
fontSize = 14.sp
fontSize = 15.sp
)
}
}
Expand Down
Loading