manger: fix lkm detection #2654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
原因请看 SukiSU-Ultra/SukiSU-Ultra#217 (comment) 文中介绍的是lkm的问题 但实测下来gki也有这样的问题 但修复方法通用
|
补充一下，是我提出的那个SukiSU内核变动版本，我看内核发送lkm模式的时候是 flag |= 0x01，第一个bit占用了，所以就拿走了第二个bit作为sukisu新版本系统启用标志，但userspace是用的 flag == 1 来判断lkm，所以炸了，建议userspace统一为内核行为来最大化兼容性 |
|
赋值在这里：https://github.com/tiann/KernelSU/blob/main/kernel/core_hook.c#L308 不可能是 0x11，除非有人改了。 |
就是因为新的 SukiSU Ultra 更改了内核版本号方案，所以才改这里（） |
|
目前 KSU 只用了第一个 bit，直接判断是否为 1 是可以用的，但内核是使用的 bitmask 难道 userspace 不应该匹配这一个行为吗？变量名也是 |
|
如果改了 kernel，就应该改 userspace；SuKiSU 是用的官方 manager 吗？ |
|
不好意思，我理解错了；我以为这边也是有这个问题的。实际上没有，但是这个逻辑更严谨。 |
管理器肯定自行改了，逻辑应该通用的吧? |
Tashar02
reviewed
Jun 26, 2025
tiann
approved these changes
Jun 27, 2025
LeCmnGend
pushed a commit
to LeCmnGend/KernelSU
that referenced
this pull request
Jun 28, 2025
原因请看 SukiSU-Ultra/SukiSU-Ultra#217 (comment) 文中介绍的是lkm的问题 但实测下来gki也有这样的问题 但修复方法通用
fadlyas07
added a commit
to bengal-upstream/KernelSU
that referenced
this pull request
Jul 10, 2025
* 'main' of https://github.com/tiann/KernelSU: kernel: selinux: rules: Fix illegal RCU lock usage in apply_kernelsu_rules() (tiann#2646) manger: fix lkm detection (tiann#2654) Update FUNDING.yml kernel: core_hook: fix refcount leaks on try_umount (tiann#2635) build(deps): bump the maven group across 1 directory with 7 updates (tiann#2629) Translations update from Hosted Weblate (tiann#2587) kernel: throne_tracker: avoid cross-fs traversal using s_magic check (tiann#2633) Switch to prepare_creds/commit_creds (tiann#2631) throne_tracker: avoid cross fs access (tiann#2626) build(deps): bump the maven group across 1 directory with 4 updates (tiann#2612) Conflicts: kernel/selinux/rules.c kernel/throne_tracker.c Change-Id: If58573ef63cb613e76d6054c898c7748143ff8b9
LeCmnGend
pushed a commit
to LeCmnGend/KernelSU
that referenced
this pull request
Jul 23, 2025
原因请看 SukiSU-Ultra/SukiSU-Ultra#217 (comment) 文中介绍的是lkm的问题 但实测下来gki也有这样的问题 但修复方法通用
fadlyas07
added a commit
to bengal-upstream/KernelSU
that referenced
this pull request
Sep 13, 2025
* 'main' of https://github.com/tiann/KernelSU: (42 commits) Unmount isolated process which forks from zygote unconditionally (tiann#2747) fix 'for' loop problem (tiann#2745) update resetprop (tiann#2733) Strip JNI debug logs on release build (tiann#2732) manager: Support search module (tiann#2730) manager: Add uninstall 2nd confirm (tiann#2729) manager: Fix some issues (tiann#2725) manager: fix button issues in module cards (tiann#2719) manager: switch ui to miuix design style (tiann#2710) Revert "Handle unmount for isolated process correctly" (tiann#2718) Handle unmount for isolated process correctly (tiann#2696) Reset seccomp filter count when escaping to root (tiann#2708) kernel: selinux: rules: Micro-optimize get_policydb() and fix illegal RCU lock usage in handle_sepolicy() (tiann#2695) Update resetprop from Magisk v30.2 (tiann#2700) ksud: support vendor_boot patching for some odd devices (tiann#2650) ksud: make clippy happy (tiann#2683) feat(ui): improve predictive back animations (tiann#2675) kernel: added new prctl CMD_GET_MANAGER_UID to get the uid of the crowned manager (tiann#2673) kernel: selinux: rules: Fix illegal RCU lock usage in apply_kernelsu_rules() (tiann#2646) manger: fix lkm detection (tiann#2654) ... Conflicts: kernel/core_hook.c kernel/selinux/rules.c kernel/throne_tracker.c Change-Id: Iebf7dd870a7d9e35f4cecbf97fa13eeb174b7b5d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
原因请看 SukiSU-Ultra/SukiSU-Ultra#217 (comment)
文中介绍的是lkm的问题 但实测下来gki也有这样的问题 但修复方法通用