Skip to content

kernel: selinux: rules: Fix illegal RCU lock usage in apply_kernelsu_rules() #2646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

kernel: selinux: rules: Fix illegal RCU lock usage in apply_kernelsu_rules() #2646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions kernel/selinux/rules.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,19 @@ static struct policydb *get_policydb(void)
return db;
}

static DEFINE_MUTEX(ksu_rules);

void apply_kernelsu_rules()
{
struct policydb *db;

if (!getenforce()) {
pr_info("SELinux permissive or disabled, apply rules!\n");
}

rcu_read_lock();
struct policydb *db = get_policydb();
mutex_lock(&ksu_rules);

db = get_policydb();

ksu_permissive(db, KERNEL_SU_DOMAIN);
ksu_typeattribute(db, KERNEL_SU_DOMAIN, "mlstrustedsubject");
Expand Down Expand Up @@ -118,11 +123,11 @@ void apply_kernelsu_rules()
// Allow all binder transactions
ksu_allow(db, ALL, KERNEL_SU_DOMAIN, "binder", ALL);

// Allow system server kill su process
ksu_allow(db, "system_server", KERNEL_SU_DOMAIN, "process", "getpgid");
ksu_allow(db, "system_server", KERNEL_SU_DOMAIN, "process", "sigkill");
// Allow system server kill su process
ksu_allow(db, "system_server", KERNEL_SU_DOMAIN, "process", "getpgid");
ksu_allow(db, "system_server", KERNEL_SU_DOMAIN, "process", "sigkill");

rcu_read_unlock();
mutex_unlock(&ksu_rules);
}

#define MAX_SEPOL_LEN 128
Expand Down
Loading