Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Refactor and add support for triggering with workflow dispatch events #32

Merged
merged 4 commits into from
Oct 16, 2020

Conversation

tiangolo
Copy link
Owner

✨ Refactor and add support for triggering with workflow dispatch events.


For this action to work, the workflow has to be on the repo before the PR that is being merged was created, so that the commit merging the PR already has the workflow, even though it actually runs on the main branch.

The main thing I want from it is to help me save time adding "latest changes" for already existing PRs.

Another option would be to rebase before merging, but that's not always possible.

This update should allow enabling a workflow dispatch, to trigger the action manually with a PR number right after merging. In those cases, it won't be as great as everything happening automatically (as for PRs created after the workflow is added), but it will still save some steps and human errors by only needing the PR number.

And it seems there's no way around it with the current available GitHub Actions events.

@tiangolo tiangolo merged commit 042d2a6 into main Oct 16, 2020
@tiangolo tiangolo deleted the workflow-dispatch branch October 16, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant