Segment labels and redirections#22
Merged
tiangolo merged 4 commits intotiangolo:masterfrom Apr 6, 2020
ldez:patch-1
Merged
Conversation
Contributor
Author
|
ping @tiangolo 😉 |
luizjr
approved these changes
Mar 25, 2020
luizjr
approved these changes
Mar 25, 2020
Owner
|
Thanks for your contribution and for taking the time to do this @ldez ! 🙇♂️ 🚀 🎉 And thanks for the patience 😅 🤓 |
Contributor
|
Hello @tiangolo, are you going to do the other merges? |
This was referenced Apr 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recommend to not add a segment to only create a HTTPS redirection.
The segments are mainly made to manage multiple ports on one container.
I created this PR because some our users follow this guide and create segments even if it's not needed.