moniter the clien connection #148
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| type Service interface { |
There was a problem hiding this comment.
Hi @Virendrapro
The code are breaking. Looks like you remove something wrong.
The new code are in the wrong file. Note that the client connection implementation is in the file https://github.com/tiagorlampert/CHAOS/blob/main/client/app/handler/handler.go#L40v
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent enhancements to the client package significantly improve WebSocket connection management. The SendCommand function now verifies client connections before command execution, ensuring commands are only sent to active clients. Additionally, robust error handling has been implemented; if a command fails, the respective connection is removed, preventing resource leakage. Connections are closed using deferred functions to guarantee proper cleanup. These changes lead to a more reliable system, effectively managing client connections and maintaining optimal performance.