Support mirror CDN for package and shared profile downloads #960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #960 +/- ##
==========================================
+ Coverage 92.93% 92.94% +0.01%
==========================================
Files 286 286
Lines 8488 8502 +14
Branches 788 790 +2
==========================================
+ Hits 7888 7902 +14
Misses 496 496
Partials 104 104 ☔ View full report in Codecov by Sentry. |
|
These shouldn't be tied to the mirror storage definitions at all, as those might have nothing to do with public-facing CDN routing. If we want to validate the domains (which is not a bad idea), add a new setting for it and go through that list instead. |
Reimplemented as:
|
anttimaki
force-pushed
the
api-mirror-cdn
branch
from
c66bc49 to
ac3779f
Compare
MythicManiac
approved these changes
Dec 18, 2023
API calls can indicate that a mirror CDN is preferred by including a query parameter in the request. The feature will be supported by the API endpoints that provide download URLs for packages and shared mod manager profiles. The backend will return URL to the preferred CDN only if the CDN is allowlisted in the config. This is a plain string replacement operation and the backend doesn't validate the URL it's about to return in any way. This is intended to solve the small but growing number of incidents where users for some reason can't access Thunderstore's main CDN. Refs TS-2003
anttimaki
force-pushed
the
api-mirror-cdn
branch
from
ac3779f to
6e1659b
Compare
MythicManiac
approved these changes
Dec 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API calls can indicate that mirror CDN is preferred by including a query paramater flag in the request. Currently this is supported by the API endpoints that provide download URLs for packages and shared mod manager profiles.
If the backend receives the query parameter flag and is configured to use MirroredS3Storage, it will try to return URLs that point to the first mirror CDN.
This is intended to solve the small but growing number of incidents where users for some reason can't access Thunderstore's main CDN.
Refs TS-2003