Feat: Update fee rate slider position to start from 1 instead of 0 #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't quite address the issue. See screenshot. You can still choose the 0.0 fee rate, it simply sets the default starting position at 1.0. |
thunderbiscuit
requested changes
Jun 25, 2023
There was a problem hiding this comment.
We'll need to make sure the slider starts at 1.0 and increments in steps of 1.0 (I think you might need to change a variable somewhere if I remember correctly that gives you the number of steps in between two numbers so that the slider shows correctly steps of 1.0).
thunderbiscuit
approved these changes
Jul 4, 2023
|
This is ready to go when you switch the account making the commit. |
Prakhar-Agarwal-byte
force-pushed
the
upd_slider_pos
branch
from
bae8d3d to
885f2c4
Compare
thunderbiscuit
force-pushed
the
upd_slider_pos
branch
from
885f2c4 to
7ea9fd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.