Feat: Show sync status #254
Conversation
There was a problem hiding this comment.
Good stuff! This had been a long-requested feature. Happy to see it being worked on. Only thing I see is that we can sort of mess with it by pressing a ton of times in a row (I even managed to get the arrows to go... backwards??? lolll don't know how that happened).
Anyway let's disable the button while it's syncing.
app/src/main/java/com/goldenraven/padawanwallet/ui/wallet/WalletRootScreen.kt
Show resolved
Hide resolved
|
@Prakhar-Agarwal-byte are you still working on this? If so you might need a quick rebase and small fixes, but otherwise looks good! |
Prakhar-Agarwal-byte
force-pushed
the
sync-status
branch
from
e1df733 to
20dca22
Compare
|
Great stuff thanks for the work. I think we still have one small bug, but not sure if I should hold off the PR for it. The icon basically starts rotating backwards forever if you press the sync button many times really quickly. It's not really a problem for syncing (the functionality still works), but it's something in the animation. Take a look if you don't mind and see if you can reproduce it locally. Don't spend too much effort if you can't fix it quickly, I think we can just open a new issue to keep track of it and fix it later on. |
|
I couldn't replicate the issue on my device. I repeatedly pressed the sync button quickly but the icon was rotating just fine. WhatsApp.Video.2023-03-22.at.11.22.12.PM.mp4 |
Fixes #252
Now the sync icon rotatation indicates that sync status.
Untitled.video.-.Made.with.Clipchamp.mp4